haoyangw / pe

0 stars 0 forks source link

Overzealous input validation for `add` command #11

Open haoyangw opened 1 year ago

haoyangw commented 1 year ago

add command doesn't support using the / character in the ingredients list, as the error message for this test command shows:

image.png

However, the / can be used in valid situations, such as to mean alternative ingredient choices, e.g. "Carrot/Radish/Potato, Water/Tea", so rejecting this valid command represents overzealous input validation. The severity is low though since most users don't need to use the / character specifically, and words can be used in place of / to work around the issue.

nus-pe-script commented 1 year ago

Team's Response

Not a bug as / is being used as a delimiter in the app hence we do not accept any additional / to prevent corruption of inputs and users may simply write "Water or Tea" to overcome the issue stated. Hence this is more of a suggestion on user preference and less of a bug report. We also stated in the UG constrain that the input handling does not accept / as shown below.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I respectfully disagree with the notion that this is not a bug.

While users can indeed write 'or' instead of '/' to temporarily workaround this issue, it causes inconvenience that worsens the user experience of your program. I disagree that this is a matter of user preference since using '/' in descriptions in general is commonplace and a valid use case, not extreme user behaviour, which is why this bug is categorised as FeatureFlaw(incomplete) rather than FunctionalityFlaw(not functioning as expected).

Mentioning the corresponding constraint in your UG also does not resolve this FeatureFlaw as that is more appropriate for addressing a FunctionalityFlaw. Hence, I disagree with your team's reasoning.