haoyangw / pe

0 stars 0 forks source link

`view` command error message incorrect #2

Open haoyangw opened 1 year ago

haoyangw commented 1 year ago

With an empty recipe list, if you issue view command with the example command from help, view Hotpot that uses recipe name not recipe index, the error message given is as follows:

image.png

Which informs the user that there is an error finding index. However, the actual error is unable to find recipe name, so the error message is incorrect.

This is a low severity bug since most users can figure out on their own what they did wrongly in such cases.

soc-se-bot commented 1 year ago

Team's Response

The "Exception occurred:" part of the error message clearly describes the error that this user is facing, which is empty list, and hence should not qualify as an invalid error message. Additionally, the program has error in finding the index of the recipe name given hence the error writes "Error in finding index".

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe you did not read my explanation carefully, and misunderstood.

I was referring to the Error in finding index part of the program's response, not the Exception occurred: part that you are intending to justify.

I find it incorrect to state that there is an error in finding index for the command that I'm testing, view Hotpot, because I'm searching for a name, using the view NAME syntax you mentioned in your UG, not an index. Since there are two different usages for the view command as described in the UG, I would expect that there should also be two different error messages for wrong usage, i.e. another error message stating that there is an error in finding name.

This is especially because users won't know your underlying implementation for your program, so they won't know that your current error message means 'the program has error in finding the index of the recipe name given', which is odd to begin with(are you saying that in your code, you search for a recipe name by finding the recipe index?).

I'm actually made even more confused by your justification, so I cannot accept it.