haozuguo / ebookdroid

Automatically exported from code.google.com/p/ebookdroid
0 stars 0 forks source link

Performance improvement suggestion #560

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Dear developers,

I am studying Ebookdroid using a static code checker. I found some potential 
slow operations in Ebookdroid's UI thread.

Android documentation says this:

http://developer.android.com/training/articles/perf-anr.html

"Any method that runs in the UI thread should do as little work as possible on 
that thread. In particular, activities should do as little as possible in key 
life-cycle methods such as onCreate() and onResume(). Potentially long running 
operations such as network or database operations, or computationally expensive 
calculations such as resizing bitmaps should be done in a worker thread (e.g., 
via AsyncTask)."

I found the following event handlers performing content resolver queries and 
touching file system:

org.ebookdroid.ui.settings.BookSettingsActivity's onCreate()
org.ebookdroid.ui.settings.SettingsActivity's onCreate()
org.ebookdroid.ui.library.BrowserActivity's onCreateContextMenu()

Do you think these slow operations will affect Ebookdroid's performance (e.g., 
making GUI not smooth enough)? If yes, perhaps moving them to a separate thread 
can help make Ebookdroid super smooth in user interaction. Looking forward to 
your reply and hope I can help improve Ebookdroid.

Original issue reported on code.google.com by yepang...@gmail.com on 25 Jul 2013 at 1:58

GoogleCodeExporter commented 9 years ago
It seems that you are investigating very very old yet GPLed version of 
EBookDroid. Since version 2.0 all core was rewtritten from scratch and we 
switched from GPLed and statically linked version to close source GUI with 
separate GPLed decoder plugins.

Original comment by Andrei.K...@gmail.com on 25 Jul 2013 at 2:40

GoogleCodeExporter commented 9 years ago
Yes. I found I have no access to newer versions :)

Original comment by yepang...@gmail.com on 25 Jul 2013 at 2:47

GoogleCodeExporter commented 9 years ago

Original comment by Alexander.V.Kasatkin@gmail.com on 25 Dec 2013 at 12:53