search

hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol
MIT License
153 stars 82 forks source link

port of #68 PR on jmDNS to latest code base #122

Closed yfre closed 3 years ago

yfre commented 3 years ago

porting the old PR with jmDNS enhancements to latest code base and updating jmDNS to latest stable version, which is 3.5.6

Signed-off-by: Eugen Freiter freiter@gmx.de

yfre commented 3 years ago

@ccutrer i have ported your older PR to latest code base. i hope it is ok for you.

ccutrer commented 3 years ago

@J-N-K will this cause compatibility issues with OpenHAB? I know netty was/is an issue, and this is another package that OpenHAB also uses itself.

gjvanderheiden commented 3 years ago

OpenHab can always choose to exclude dependencies. Locally updated mdns and it runs with no issues. Same with netty. HAP-java also uses

org.zeromq curve25519-java 0.1.0

which can be deleted with no issues. (I've updated the other libs crypto deps locally too, maybe that's why. My favourate quote: -"Works on my machine" +"But we don't ship your machine, do we?" Don't know the original creator of that quote, sorry).

If you can update the deps with no issues, openhab can use the old stone age stuff if they choose to do so. It will still be compatible.

Really dislike not updating because of other projects. It's very well meant and carefull to OpenHab. But this way nobody moves.

yfre commented 3 years ago

just checked and openhab was upgraded to jmdns 3.5.6

https://github.com/openhab/openhab-core/pull/1721

i see this version also in my openhab3 setup