search

hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol
MIT License
155 stars 82 forks source link

add back fanv1 service #166

Closed ccutrer closed 2 years ago

ccutrer commented 2 years ago

the Home app doesn't let you customize the icon for a FanV2 (i.e. to show a ceiling fan).

I'm not sure if I'm ready to merge this yet. I've got it plumbed through to OpenHAB as well https://github.com/ccutrer/openhab-addons/commit/114fe0625d226098504a89243e763049abc53c42. When I tested, the accessory works as expected, EXCEPT that on iOS 16, the new Home refuses to show the fan anywhere except for if you go to the hub and list its accessories. Or if it's on it does show on the top status line of a room. This feels like an iOS bug to me. So I'm going to let this hang out here until the next iOS update comes, and test again.

ccutrer commented 2 years ago

@yfre Okay... I want to merge this now. Apparently iOS doesn't like when a basic fan isn't 0-100%, but is fine with a FanV2 being 0-4 speeds. Restoring it to be on a Dimmer item it's working fine in iOS.

yfre commented 2 years ago

@yfre Okay... I want to merge this now. Apparently iOS doesn't like when a basic fan isn't 0-100%, but is fine with a FanV2 being 0-4 speeds. Restoring it to be on a Dimmer item it's working fine in iOS.

interesting. yes, the PR looks for me.