Clear all connections in SessionManager during HomekitRoot.stop()

hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol

MIT License

152 stars 83 forks source link

Clear all connections in SessionManager during HomekitRoot.stop() #55

Closed timcharper closed 5 years ago

timcharper commented 5 years ago

This is an attempt to resolve issue #54, which I've observed during development of the Openhab2 homekit addon.

timcharper commented 5 years ago

In order to reduce the turmoil of whitespace diffs, this PR is based on PR #53; we should decide and merge it before merging this, if this patch ends up being the right way to solve issue #54 .

The unique part of this PR is in https://github.com/beowulfe/HAP-Java/pull/55/commits/7e8f98e292345a46510e1827b2f1b3e2777f1415

andylintner commented 5 years ago

Just rerunning the CI on this after merging #53, then I'll merge this as well.

timcharper commented 5 years ago

@beowulfe I wasn't sure if this was the ideal way to solve this and was hoping to get your opinion on it first; I guess it seemed like a reasonable solution? :)

andylintner commented 5 years ago

@timcharper - yep, I think it's great. I've used checkstyle in the past, but I don't have an opinion on it vs google's.