hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol
MIT License
153 stars 82 forks source link

TargetThermostatMode and ThermostatMode erroneously assumed equivalent #60

Closed timcharper closed 4 years ago

timcharper commented 5 years ago

TargetThermostatMode is described by the following enums:

(See https://github.com/KhaosT/HAP-NodeJS/blob/master/lib/gen/HomeKitTypes.js#L2342)

CurrentThermostatMode is described by a similar, but reduced, set of values:

(See https://github.com/KhaosT/HAP-NodeJS/blob/master/lib/gen/HomeKitTypes.js#L555)

It would be illegal for a thermostat to report itself as currently "autoing" the house, per the spec.

timcharper commented 5 years ago

@beowulfe #62 is the fix which takes the approach you suggested, and preserved backwards compatibility