Split ThermostatMode enum into specific enums that cover each value space

hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol

MIT License

152 stars 83 forks source link

Split ThermostatMode enum into specific enums that cover each value space #61

Closed timcharper closed 5 years ago

timcharper commented 5 years ago

TargetHeatingMode has 4 enum values, while CurrentHeatingMode only has 3.

Fixes #60

timcharper commented 5 years ago

@beowulfe this is a compatibility breaking change. I don't know if we can do it reasonably without a breaking change, however. Any thoughts ? Should it be merged to a future 1.2.x branch?

andylintner commented 5 years ago

Yeah, let's hold onto this. I want to get a last 1.1.x version published.

If you wanted a temp fix, we could log a warning when the AUTO mode is used for current, and send OFF instead.

timcharper commented 5 years ago

@beowulfe that's a great idea, I'll submit the fix for that. Let's label this PR as hold for now?