Bugfix: TargetHeatingMode and CurrentHeatingMode disparity (backwards compatible)

hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol

MIT License

152 stars 83 forks source link

Bugfix: TargetHeatingMode and CurrentHeatingMode disparity (backwards compatible) #62

Closed timcharper closed 5 years ago

timcharper commented 5 years ago

TargetHeatingMode has 4 enum values, while CurrentHeatingMode only has 3. We log a warning if ThermostatMode.AUTO is used for CurrentHeatingCoolingModeCharacteristic, and return OFF instead.

Fixes #60

timcharper commented 5 years ago

@beowulfe any hesitancy to merging this one? It retains backwards compatibility.

timcharper commented 5 years ago

After some thought, I'm closing this one. It doesn't add a lot of value, and, technically, we're breaking backwards compat by changing the method signature of protected method for a public class.