search

hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol
MIT License
152 stars 83 forks source link

make optional fan characteristics... optional #76

Closed ccutrer closed 4 years ago

jrburk commented 5 years ago

HomekitServer.getVersion() to retrieve the API Version like 1.2.0-snapshot would be very helpful.

sobeos commented 4 years ago

What is the status of the pull request? It is open since March. In my oppinion @ccutrer raised a basic design decision here: How to handle optional characteristics. The initial approach used for lights was nice, but does not work in common. There are accessories with to many optional characteristics. I'm implementing the tv interface at the moment, facing the same problem. I think @ccutrer's suggestion is good and feasable. I would suggest one inteface class for every (optional) characteristic. At least we should agree on one pattern. No decision at all is the badest approach.