search

hap-java / HAP-Java

Java implementation of the HomeKit Accessory Protocol
MIT License
152 stars 83 forks source link

Thermostat no longer working on iOS 13.x #86

Closed amedeomantica closed 4 years ago

amedeomantica commented 4 years ago

Hi, with iOS 13.x is no longer possible to set thermostat(s) temperature, I'm not sure if this is an iOS bug or something going wrong in the protocol. Temperature set won't move from Zero. Current temperature is correctly reported

image

yfre commented 4 years ago

confirm. i have the same issue. but during this process - changing target temprature - there is not communication between home app and the server / java hap. either something is missing /wrong in the thermostat description provided at the beginning by java hap or it is ios13 bug.

@amedeomantica what do you use as server - openhab?

sebasanblas commented 4 years ago

Confirm too. I have the same issue.

amedeomantica commented 4 years ago

@yfre no, I run a Java Play framework app

yfre commented 4 years ago

reason found - ios13 expects the temperature unit (celsius, fahrenheit) to be changeable but we had them read only. i would say, pretty strange behaviour of ios13 home app, but anyway - it is right, according to HAP protocol the temperature unit is read & write.

pull request with the fix is created. there are not breaking API changes, so, drop-in replacement of hap jar should work

https://github.com/hap-java/HAP-Java/pull/87

amedeomantica commented 4 years ago

@yfre cool, I just tested your patch, it works! Thank you