search

hape42 / dailygammon

DailyGammon-app is free and ad-free client for the long-running DailyGammon web-based application.
https://hape42.de/RoadMap
16 stars 6 forks source link

build info #16

Closed hape42 closed 2 years ago

hape42 commented 2 years ago

Each build increments a counter. this is triggered by buildinfo.sh. And in info.plist the counter is written. This means that each comitt also unnecessarily changes info.plist.

Alone this was not a big problem.

But now in the team there must be another solution for a build-info.

MyMattes commented 2 years ago

I'd suggest to use the build directory instead of the info.plist at its source location: This way the build product will have the correct build number, but the git-controlled source code remains unchanged. Could be achieved by using this path assignment: plist="${TARGET_BUILD_DIR}/${INFOPLIST_PATH}"

MyMattes commented 2 years ago

I changed buildinfo.sh to work with git information exclusively to determine app version and build number: As a change not every single build is counted (but commits) and a new app version is reflected by a git tag. The Settings bundle is automatically updated. Here's the pull request: #36