search

hape42 / dailygammon

DailyGammon-app is free and ad-free client for the long-running DailyGammon web-based application.
https://hape42.de/RoadMap
16 stars 6 forks source link

Quote previous message #44

Closed hape42 closed 1 year ago

hape42 commented 1 year ago

Customer wrote:

My opponent (smiles2go) responded to my previous message (Thanks for the match. Better luck in your others. Looking fwd to next time. . Stay healthy!". The reply (Thx. GL) should have appeared after "smiles2go says:" and "Quote previous message" should not have been displayed.

20221207Screenshot_from_interaction_iOS

kagsteiner commented 1 year ago

I must confess, I don't get it. I don't even know what the screenshot shows. This seems to be the web UI, showing the final entry of a match review. Never had a "reply to " button there, never had messages shown there... Is that the Chrome browser extension at work?

Do you know how to reproduce the issue?

C4rsten commented 1 year ago

Yes, I believe the reply button is added by the Chrome extension, but that is not the point. The error is that the placeholder text "Quote previous message" found its way into the reply. I noticed in earlier versions that it was possible to edit the placeholder text, which made me nervous, because I couldn't be sure what was sent in the end.

Smiles2go commented 1 year ago

I am the Smiles2go in the story. I was using DG 1.4.3 beta (just loaded 1.4.4) on iPhone. Issue is related to DG at end of game and end of match offering player to send message back to opponent, but prepopulates message composition pane (1) with text that is inconsistent and (2) not all of which should be sent, and (3) is poorly presented on my iPhone. I didn't think to save screenshot of the instance reported here but have saved a couple others. Opponent posting originally is using (I think) a Firefox extension as his client.

Sub-issue (1) inconsistent presentation:

image

Above screenshot is like what I saw on my end of the originally reported issue. Obviously "Quote previous message" part doesn't make much sense, though is good to show me what other guy may have sent earlier. All I typed is at very bottom, but I am able to edit any of the text.

image

Above is simpler end-game message, with less mess, inconsistent with other example. Maybe differs because opponent didn't send text first.

image

Sub-issue (2): at completion of composition, full text in pane is sent, making it unclear what parts are quoted, what is new, and including spurious things like "Quote previous message" if was present. Issue is really less about sending extra text, and more about pre-populating with unuseful text.

Sub-issue (3): These messages are challenging to compose / edit on (just my?) iPhone. Text pane is tiny compared to keyboard, and keyboard often obscures text as it is being entered. Can sometimes nudge text-entry pane up to make new text visible, but not always. As bad as this looks, was even worse before I learned how to turn off the suggested-words bar that appears immediately above keyboard by default - with suggestions-bar I can sometimes not see any of what is being typed. This on iPhone 14Pro, latest iOS then-available. This sub-issue (editing UI) is much less a problem on iPad where there is so much more screen space. But strange pre-populated text does occur there too.