NSInvalidArgumentException (NULL string passed) in readPlayerArray, when clicking on opponent name that contains spaces

[kagsteiner]

Steps to reproduce:

1. click on a match against an opponent with a space in her/his name (e.g. "caveat emptor" or "Cosmo Tertl")
2. click on the name of the player in the top right corner.
3. app crashes Happens on iPad and iPhone

Stack trace: 3 DailyGammon 0x0000000102f9cd3c -[Player readPlayerArray:] + 180 4 DailyGammon 0x0000000102f9af10 -[Player viewDidLoad] + 2116 5 UIKitCore 0x000000010b08e7ec -[UIViewController _sendViewDidLoadWithAppearanceProxyObjectTaggingEnabled] + 80

here's where it crashes (Player.m): -(void)readPlayerArray:(NSString*)searchLink {

NSURL *urlTopPage = [NSURL URLWithString:searchLink];
NSData *topPageHtmlData = [NSData dataWithContentsOfURL:urlTopPage];

**NSString *htmlString = [NSString stringWithUTF8String:[topPageHtmlData bytes]];**

Seems the searchLink must be quoted. It's searchLink __NSCFString * @"http://dailygammon.com/bg/plist?like=caveat emptor&type=name" 0x0000600000abf2f0 and probably should have a %20 or so where the " " between caveat emptor is?

[kagsteiner]

With such a user name, NSURL *urlTopPage = [NSURL URLWithString:searchLink]; in Player.m already returns nil.

[kagsteiner]

Trying to fix this... (trembles slightly)

[kagsteiner]

yes, my mighty fix seems to work!

[kagsteiner]

seems to work