hapi-server / server-java

Java-based server which works with Java-based web servers like Tomcat
Apache License 2.0
0 stars 1 forks source link

ESAC server C4_CP_STA_CS_NBR inconsistent #21

Open jbfaden opened 1 year ago

jbfaden commented 1 year ago

The dataset id C4_CP_STA_CS_NBR fails on the server because the CEF version of the data has its second parameter, Frequency__C4_CP_STA_CS_NBR, defined as non-time-varying DATA; while the XML version indicates the variable will be time-varying. Compare:

wget -O C4_CP_STA_CS_NBR.xml 'https://csa.esac.esa.int/csa-sl-tap/data?retrieval_type=HEADER&DATASET_ID=C4_CP_STA_CS_NBR&FORCEPACK=false'

which indicates there should be 1+128+128*3*2=897 fields, while

wget -O C4_CP_STA_CS_NBR.cef "https://csa.esac.esa.int/csa-sl-tap/data?RETRIEVAL_TYPE=product&RETRIEVAL_ACCESS=streamed&DATASET_ID=C4_CP_STA_CS_NBR&START_DATE=2022-07-31T11:00:00Z&END_DATE=2022-07-31T12:00:00Z"

returns 1+128*3*2=769 fields.

jbfaden commented 1 year ago

I found another case where the CEF has constant data in the header and the xml response doesn't have data there, so I assume it's going to be in the CEF response records:

wget -O C1_PP_WHI.xml 'https://csa.esac.esa.int/csa-sl-tap/data?retrieval_type=HEADER&DATASET_ID=C1_PP_WHI&FORCEPACK=false'

doesn't have a DATA node for half_interval__C1_PP_WHI, while

wget -O C1_PP_WHI.cef "https://csa.esac.esa.int/csa-sl-tap/data?RETRIEVAL_TYPE=product&RETRIEVAL_ACCESS=streamed&DATASET_ID=C1_PP_WHI&START_DATE=2012-07-31T11:00:00Z&END_DATE=2012-07-31T12:00:00Z"

does have DATA in the CEF header.

herroyalmaj commented 3 months ago

Hi Jeremy, Going over old tickets, I checked these and the XMLs and CEFs both do contain the DATA field for those variables, so could you please check if you are still getting these errors? Thanks! Helen

jbfaden commented 3 months ago

Thanks for looking at this, Helen. I think things have changed on your end, because the CEF parser I use (which I wrote many years ago) doesn't seem to read in the data properly. I'm sure this is a problem on my end, and I'll make sure that gets fixed. Once that's done I'll verify that I can read this stream properly into the HAPI server.