search

hapifhir / hapi-fhir-android-integration-test

Hapi FHIR android Integration Test
Apache License 2.0
7 stars 7 forks source link

Android chore update for fhir north #1

Closed markiantorno closed 7 years ago

markiantorno commented 7 years ago

Let me know if this is appropriate for this project, or if this should be in it's own thing. I wanted to update the tools for the FHIR north thing this Wednesday.

Any feedback is welcome.

jamesagnew commented 7 years ago

@botunge would you be able to give this a review? Mark works with me at University Health Network and has beefed this up to use as a demo for an upcoming connectathon. Would love to get your thoughts on the updates.

jamesagnew commented 7 years ago

Hmm, travis CI seems to have failed.. i wonder what's going on there

botunge commented 7 years ago

I'll take a look at the code in a couple og hours

Den søn. 23. apr. 2017 20.33 skrev James Agnew notifications@github.com:

Hmm, travis CI seems to have failed.. i wonder what's going on there

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/hapifhir/hapi-fhir-android-integration-test/pull/1#issuecomment-296474688, or mute the thread https://github.com/notifications/unsubscribe-auth/AM2_I4dZcV57UrYSmIuErKkYSydSIazkks5ry5mRgaJpZM4NFfZx .

jamesagnew commented 7 years ago

Thanks!

@markiantorno I think you need to update the android lib version in .travis.yml in order for the CI server to build correctly.

markiantorno commented 7 years ago

Yeah I pooched that

sorry

markiantorno commented 7 years ago

As a side note, @botunge I'm planning on adding a Observation UI similar to the patient one, probably tomorrow.

botunge commented 7 years ago

the purpose of the project was to ensure that hapi-fhir would work in Android. This commit takes the project in another direction. I like the idea of a android client showcasing different usages of the FHIR api. Just not sure it should be merged with this, since this is only here to ensure no changes are committed to HAPI which brakes Android. @jamesagnew Why not make a hapifhir/androidshowcase project or something like that, where this change could be put. AFAIK the code is fine. (you might want to remove some create by mark comments and add som Apache 2 Copyright notice.)

markiantorno commented 7 years ago

Yeah, James had suggested something along those lines and I agree it probably would be best to put it in its own repo. @jamesagnew would you rather I do this under my own GitHub account or nested under fhir? For the short term, I'm just going to put it under my GitHub account so that it's ready for the conference on Wednesday.

markiantorno commented 7 years ago

Thanks for taking the time to look at it @botunge.

jamesagnew commented 7 years ago

@markiantorno if you're interested in posting this as a project right in this organization I certainly wouldn't object :)