search

hapifhir / hapi-fhir-jpaserver-starter

Apache License 2.0
397 stars 1.06k forks source link

Docker image tags mismatch with HAPI FHIR version #664

Open gmej opened 8 months ago

gmej commented 8 months ago

I have deployed with Helm, with the following config in values.yaml

image:
  registry: docker.io
  repository: hapiproject/hapi
  tag: "v7.0.2"
  pullPolicy: Always

But the /metadata endpoint reports being v7.0.0

{
    ...
    "software": {
        "name": "HAPI FHIR Server",
        "version": "7.0.0"
    }
    ...
}

Is this a problem on my side? Or maybe Docker images aren't correctly tagged? Building source (in version v7.0.2) in a new Docker Image does report the correct version "v7.0.2" in the /metadata endpoint

chgl commented 6 months ago

I deliberately proposed to be able to decouple image builds from releases in the repository back in https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/217. That being said, I agree that this can be confusing since usually a new image is only built and released when a new hapi fhir version is available.

So instead of building a new image only if a tag looking like image/vX.Y.Z is created, I wouldnt mind changing the workflow to build a new image on regular tags which correspond to the hapi fhir version (the downside of course being that hapi-fhir-jpaserver-starter specific changes have to happen in-sync with upstream releases in the https://github.com/hapifhir/hapi-fhir repo to keep the releases and tags consistent.