search

hapifhir / hapi-hl7v2

277 stars 138 forks source link

Absence of generic class MDM_TXX and ORU_RXX #102

Open Bhavishya-jasuja opened 11 months ago

Bhavishya-jasuja commented 11 months ago

As I observe, we have ADT_XXX for all our ADT events. However, we don't seem to have a similar prefix for our MDM and ORU events. Is there any specific reason for this inconsistency? To ensure clarity and maintainability in our codebase, I feel that we should have MDM_TXX as well as ORU_RXX in the library so that code implementation can be used in more dynamic scenarios. Let's discuss whether there's a valid reason for not having a prefix for MDM and ORU events or if it's an oversight that needs to be addressed.

If no one has contributed to this issue yet, I'd like to express my interest in contributing to it. I believe resolving this inconsistency can improve the overall organization of our codebase and make it easier for developers to work with our event system. Please let me know how I can get started with this contribution, including any guidelines or specific steps to follow.

milkshakeuk commented 11 months ago

Are you referring to this by any chance?

https://hapifhir.github.io/hapi-hl7v2/hapi-faq.html#missing_messages

jamesagnew commented 11 months ago

We have never created any generic structures for other message types because nobody has ever needed any. If you wanted to try and modify the generator to also generate other types, we'd certainly be willing to look at the PR.