Optional second param for Boom.isBoom() to verify status code - Githubissues

hapijs / boom

HTTP-friendly error objects

Other

2.94k stars 192 forks source link

Optional second param for Boom.isBoom() to verify status code #265

Closed dominykas closed 4 years ago

dominykas commented 4 years ago

Support plan

which support plan is this issue covered by? (e.g. Community, Core, Plus, or Enterprise): community
is this issue currently blocking your project? (yes/no): no
is this issue affecting a production system? (yes/no): no

Context

node version: 12.15.0
module version: 9.0.0
environment (e.g. node, browser, native): node
used with (e.g. hapi application, another framework, standalone, ...): Wreck
any other relevant information:

What problem are you trying to solve?

When catching Boom errors and handling specific response codes, one has to check for:

Boom.isBoom(err) && err.output.statusCode === 404

This needs extra coverage for the && condition.

It would be handy to just be able to say Boom.isBoom(err, 404) or Boom.isBoom(err, { statusCode: 404 }).

Do you have a new or modified API suggestion to solve the problem?

See above.

Happy to PR.