fix: add isMissing to boom on types

hapijs / boom

HTTP-friendly error objects

Other

2.94k stars 192 forks source link

Closed damusix closed 2 years ago

devinivy commented 2 years ago

I merged this, but ended-up reverting, as the isMissing is already handled in the types (https://github.com/hapijs/boom/blob/c2293a2d1a472f1f30a941a1bdfcc5bf6789f023/lib/index.d.ts#L198-L204), and this change actually made boom's type tests fail. If we want to make a change like this I think it requires a closer look.

damusix commented 2 years ago

@devinivy I do apologize. Will definitely be more careful next time!

devinivy commented 2 years ago

No worries! I missed it too. I am not sure why CI didn't run properly for this PR, but I think that would have cleared it up pretty quickly for us.