search

hapijs / catbox-memory

Memory adapter for catbox
Other
33 stars 30 forks source link

add note to readme about the limitation of ttl #37

Closed paulovieira closed 8 years ago

Marsup commented 8 years ago

You misunderstood me, big-time needs to be added to the library, you don't have the possibility to override it externally.

paulovieira commented 8 years ago

Yeah, I got it. The user would have to patch the module directly (easy fix). The note should be more clear though. But let's wait to see if @cjihrig wants to add it directly or via some kind of option.

cjihrig commented 8 years ago

I'm open to using big-time. I actually tried this before in #29, but @hueniverse said no because it required babel (rest params). However, this is no longer the case in Node 6.

@hueniverse are you still 👎 on the idea?

cjihrig commented 8 years ago

FYI - big-time is now updated to drop Babel as of https://github.com/continuationlabs/big-time/pull/15

paulovieira commented 8 years ago

The pr has been updated.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.