search

hapijs / catbox-memory

Memory adapter for catbox
Other
33 stars 30 forks source link

Buffers can change while in cache #55

Closed kanongil closed 6 years ago

kanongil commented 6 years ago

With allowMixedContent = true, the stored buffers can be modified by writing to the returned Buffer item from a get() call.

I suspect another copy() is required on get() to handle this since there are no read-only buffers.

hueniverse commented 6 years ago

I'm ok with adding a config to change this, but otherwise this is an overkill.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.