search

hapijs / catbox-redis

Redis adapter for catbox
Other
69 stars 63 forks source link

update deps and use travis templates #117

Closed cjihrig closed 4 years ago

geek commented 4 years ago

Looks like the message returned from redis changed, can probably update https://github.com/hapijs/catbox-redis/blob/2d77699da5668d17197da399111d7e1b74a4d4cf/test/index.js#L413 to something like: "does not require a password, but a password was supplied"

cjihrig commented 4 years ago

@geek I updated the test whose error message had changed. I also got rid of the Travis dependency on redis by pushing everything into the docker-compose. As a result, I ended up mocking the one Unix Domain Socket test because Docker didn't seem to allow the host and container to share the same UDS.

lloydbenson commented 4 years ago

This is great work thanks so much @cjihrig.