search

hapijs / catbox

Multi-strategy object caching service
Other
494 stars 72 forks source link

Allow time zone specification for expiresAt values. #132

Closed jagoda closed 9 years ago

jagoda commented 9 years ago

This change introduces a 'timezone' option for cache policy objects that determines which time zone the 'expiresAt' time is relative to. Time zones may be specified either as a fixed offset (ex. -0800) or as a IANA time zone name (ex. America/Los_Angeles). When using a named time zone, daylight savings time will be accounted for automatically.

Closes #112.

hueniverse commented 9 years ago

Had to revert it after noticing it uses a new dependency that's < 1.0.0. I am having seconds thoughts about this feature. I don't think it's worth the complexity it will introduce. Things have been working well without it for 4 years... :-)

jagoda commented 9 years ago

Oops! Sorry about the < 1.0.0 dependency. I tried to do my best about following the guidelines and just missed it. No hurt feelings here about it not getting accepted. I just saw it as an interesting problem to look at during some free time.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.