search

hapijs / catbox

Multi-strategy object caching service
Other
494 stars 72 forks source link

Support ioredis client option for catbox-redis #206

Closed willrstern closed 5 years ago

willrstern commented 5 years ago

catbox-redis should support passing a custom ioredis client via the client option, but Hoek's merge breaks the ioredis instance - I believe because context is lost.

Using Object.assign works.

Supporting client is required as you have to create a more custom ioredis instance for cluster support.

willrstern commented 5 years ago

Just a ping on this...any issues with this getting merged in?

willrstern commented 5 years ago

This will also create a solution for https://github.com/hapijs/catbox-redis/pull/94 by allowing for passing in an ioredis cluster instance directly to Catbox. Connecting to a Redis cluster is how I found this bug.

daveashworth commented 5 years ago

Any updates on merging this @kanongil? Would love to take advantage of this change! 😄

kanongil commented 5 years ago

10.0.6 has been published – sorry about the delay.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.