search

hapijs / catbox

Multi-strategy object caching service
Other
494 stars 72 forks source link

Use catbox specific domain for clients and timeout #64

Closed kpdecker closed 10 years ago

kpdecker commented 10 years ago

Avoids both leaks due to domains being retained for cache operations and the possibility that disposed domains can interrupt our long running cache processes.

Fixes #63

hueniverse commented 10 years ago

I need to review this with hapi. I don't like this solution.

kpdecker commented 10 years ago

@hueniverse Two other things to consider when looking at the hapi impl:

  1. https://github.com/spumko/good/blob/master/lib/monitor.js#L716 suffers from the same issue, but retains a much smaller number of domains due to only having a few files at a given time.
  2. https://github.com/spumko/hapi/pull/1619 is somewhat related but won't resolve this issue or (1) as its focus more on Domains being associated with objects created outside of the current domain's execution path
hueniverse commented 10 years ago

I don't think this is right. It is basically going against the purpose of using domains. I am going to resolve the specific issue with hapi requests on the hapi side.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.