hapijs / cookie

Cookie authentication plugin
Other
229 stars 100 forks source link

Do not redecorate the request object if already decorated #152

Closed gordysc closed 7 years ago

gordysc commented 7 years ago

I have a separate PR opened against Hapi to allow for someone to check if a request object is already decorated with a method. However, that should only affect people using HapiJS 16.0.X. This PR can be used with previous versions of Hapi, as the underlying logic is still there.

This addresses https://github.com/hapijs/hapi-auth-cookie/issues/119

gordysc commented 7 years ago

@jaw187 hope you had a great holiday season! Any shot we could get this merged in/reviewed?

xGouley commented 7 years ago

+1 this feature should be great... ... Really great... [edit 2016-02-03] ... OK, I fork... [edit 2016-02-06]

jaw187 commented 7 years ago

https://github.com/hapijs/hapi/pull/3409

gordysc commented 7 years ago

@xGouley this has been merged, just waiting on a new version to be released 👍 @jaw187 do we have a timetable of when this will be?

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.