search

hapijs / crumb

CSRF crumb generation and validation for hapi
Other
171 stars 50 forks source link

Logunauthorized to 6.x.x - addresses #56 #113

Closed spanditcaa closed 6 years ago

spanditcaa commented 6 years ago

This establishes a pre-hapi 17 6.x.x branch of crumb, and then adds a logUnauthorized option (default false) which calls request.log(['crumb'], 'validation failed') if enabled, when crumb denies a request.

spanditcaa commented 6 years ago

The failing tests pass with hapi 16 -- would you rather update the tests for lower versions, or update the dev dependency ?

spanditcaa commented 6 years ago

Thanks for the feedback on the other PR @geek - any thoughts on the above question about hapi version ? I'll make the test and tag changes here as well.

geek commented 6 years ago

I think you are fine to update those dev dependencies. Do you need a 6.x.x release for this change?

spanditcaa commented 6 years ago

Yes, and I pushed up a 6.x.x branch with 6.0.3 (the last 6.x release) @geek - thanks.

spanditcaa commented 6 years ago

@geek I've updated both PRs.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.