search

hapijs / crumb

CSRF crumb generation and validation for hapi
Other
171 stars 50 forks source link

Heroku disallows host binding but Crumb requires it #68

Closed davemackintosh closed 8 years ago

davemackintosh commented 8 years ago

I'm stuck in a situation where I need to deploy to Heroku which disallows the binding of a host name (doesn't bind/mount) but Crumb requires I bind to a host in order to work.

Is there a solution to this type of catch-22?

stongo commented 8 years ago

It's currently required for checking for origins with CORS, but this will soon be handled by an exposed function from Hapi core https://github.com/hapijs/hapi/issues/2936. This should eliminate your issue in the next version of Crumb.

On 2015-11-23 9:07 AM, Dave Mackintosh wrote:

I'm stuck in a situation where I need to deploy to Heroku which disallows the binding of a host name (doesn't bind/mount) but Crumb requires I bind to a host in order to work.

Is there a solution to this type of catch-22?

— Reply to this email directly or view it on GitHub https://github.com/hapijs/crumb/issues/68.

stongo commented 8 years ago

This is no longer required in 6.0.0

davemackintosh commented 8 years ago

Will test on Monday, thanks everyone.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.