6.0.1 update breaks route-restful option

[gdibble]

An || got change to an &&:

[stongo]

isn't the && correct? the route setting should precede the plugin setting in the check and both conditions should pass.

[gdibble]

I thought so too, but in application my routes which specify...

    config: {
        plugins: {
            crumb: {
                restful: false
            }
        }
    }

...stopped working (whereas these send a form-field-value instead of req. header) when I upgraded to v6.0.1

Sorry if I've misintrepreted anything, I just couldn't get it to work w/o changing that && => ||

---

btw sorry I haven't done more; trying to prep for nodebots classes for 100 students so i have a lot of code & curriculum to write at the moment; after i hope to do more investigation & check the tests/etc

[aef-]

We need to add a condition that explicitly checks for false as the value and to short-circuit the plugin/settings config condition.

I think this should do the trick (test ln 659 should expect 200 instead of 403, this causes it to fail appropriately)

const routeIsRestful = request.route.settings.plugins._crumb ? 
                       request.route.settings.plugins._crumb.restful : undefined;
 if (routeIsRestful === false ||
     (routeIsRestful !== true && settings.restful === false))

[stongo]

The pull request of branch route-config should fix this. Can anyone confirm?

[stongo]

Fixed by release 6.0.2

[gdibble]

Many thanks

[lock[bot]]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.