2.9.0 rules - Githubissues

hapijs / eslint-config-hapi

Shareable ESLint config for the hapi ecosystem

Other

22 stars 23 forks source link

2.9.0 rules #37

Closed AdriVanHoudt closed 8 years ago

AdriVanHoudt commented 8 years ago

Any thoughts on the new rules from 2.9?

http://eslint.org/docs/rules/no-unsafe-finally
http://eslint.org/docs/rules/no-useless-computed-key

Both seems fine to enable?

cjihrig commented 8 years ago

Yea, these both make sense to me.

AdriVanHoudt commented 8 years ago

Want a PR?

cjihrig commented 8 years ago

Sure. I'm not going to make a new release until https://github.com/hapijs/contrib/issues/83 is resolved, but no harm PRing these right now.

cjihrig commented 8 years ago

Closed in 9a91980ace00d3cd28f4add7aa0c54b4d170f07a

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.