search

hapijs / eslint-config-hapi

Shareable ESLint config for the hapi ecosystem
Other
22 stars 23 forks source link

2.9 #38

Closed AdriVanHoudt closed 8 years ago

AdriVanHoudt commented 8 years ago

For #37

I fixed a test and added the new rules. Do you want me to convert all rules to new string syntax or do you prefer the numbers? Also do you want me to include tests for the new rules?

cjihrig commented 8 years ago

Do you want me to convert all rules to new string syntax or do you prefer the numbers?

If you wouldn't mind, that would be great. Whichever route we go, we should be consistent though.

Also do you want me to include tests for the new rules?

Yes, please.

AdriVanHoudt commented 8 years ago

@cjihrig I did see that eslint docs do not prefer string over number just states "'error' or 2" so...

cjihrig commented 8 years ago

IMO strings are more developer friendly.

AdriVanHoudt commented 8 years ago

@cjihrig 1 test error https://travis-ci.org/continuationlabs/eslint-config-hapi/jobs/127603105#L219 not sure what happened. I can update the travis to also include v6? and maybe remove the old iojs's?

cjihrig commented 8 years ago

Wow, don't see segmentation faults every day. Yea, we only need to support 4, 5, and 6.

AdriVanHoudt commented 8 years ago

@cjihrig all green now 🎉

cjihrig commented 8 years ago

Awesome. Thank you!

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.