csrl
commented
6 years ago The reason the clone is there is in order to not modify the input arguments, and thus modify the caller's manifest.
The reason unknown fields are allowed, is so that any of the registration override fields allowed in https://hapijs.com/api#serverregisterplugins-options-callback are supported eg. 'once', 'select', 'routes'. However, those technically aren't needed, since we only allow a single plugin per registration call anyway, so it is a redundant use case that we don't need to support. So I'm ok with removing that support.
Whatever approach you take, ensure the inputs arguments are not modified (eg. the caller's manifest should be the exact object before and after calling compose.
WesTyler
lock[bot]
Glue currently preserves and passes through unknown plugin attributes to the hapi registration method as seen here.
According to the hapi tests, these are simply ignored.
Is there any problem with me removing the Hoek.cloneWithShallow found here since those properties do not need to be kept? I'm having to rewrite the parsePlugin method to support hapi v17 anyways, and the Hoek clone is making it more complicated.