search

hapijs / glue

Server composer for hapi.js
Other
245 stars 62 forks source link

Update API.md #108

Closed thejones closed 6 years ago

thejones commented 6 years ago

Path to https://hapijs.com/api/17.1.1#server.dependency()

WesTyler commented 6 years ago

https://hapijs.com/api#-serverdependencydependencies-after ?

none of the #server.dependency() links actually anchor to any section for me.

csrl commented 6 years ago

Weird. The disconnect is that if you go to https://hapijs.com/api and click on the nav menu on the right, the anchor #server.dependency() is shown. But if you navigate directly to that, it doesn't work.

Your final link does work for me, so let's go with that.

WesTyler commented 6 years ago

Ah, I see. That makes sense. :+1:

csrl commented 6 years ago

I'll hold off on merging this until we see what hapijs/hapijs.com#527 comes back with.

Also, please update your PR to a single commit with a relevant commit message.

csrl commented 6 years ago

I resolved this for now by making the hapi doc links generic until hapijs/hapijs.com#527 is dealt with. Unless we can expect stable links, there isn't much point in providing them when they can go stale at any moment.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.