search

hapijs / glue

Server composer for hapi.js
Other
245 stars 62 forks source link

Updates to hapi 18; refactors cache.engine to cache.provider #124

Closed WesTyler closed 5 years ago

WesTyler commented 5 years ago

So I'm not 100% sure, but I believe from checking the Release Notes that these cache.engine ->> cache.provider manifest and config renames are the only changes for server provisioning.

Let me know if there's anything I need to change, or if I missed anything. :)

montumodi commented 5 years ago

Are we planning to publish this change anytime soon? We are planning to migrate to hapi 18 but need Glue to be hapi 18 compatible.

csrl commented 5 years ago

It looks like we'll have to do a major glue release, since it breaks compatibility.

WesTyler commented 5 years ago

Yeah unfortunately I think you’re right.

I considered keeping engines in the manifest and just mapping it to prevent breaking , but it felt wrong to have that server option mismatch.

On Tue, Jan 22, 2019 at 7:40 AM csrl notifications@github.com wrote:

It looks like we'll have to do a major glue release, since it breaks compatibility.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hapijs/glue/pull/124#issuecomment-456402401, or mute the thread https://github.com/notifications/unsubscribe-auth/ALl4O6zpTXDip-mWIBeiUxKB_wHCl_Dkks5vFxS_gaJpZM4aJWb8 .

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.