hapijs / glue

Server composer for hapi.js
Other
245 stars 62 forks source link

update to es6 based hapi style guide and lab 7 + Dependencies update #42

Closed vdeturckheim closed 8 years ago

vdeturckheim commented 9 years ago

Related to #41

Depedencies

Build is passing with Lab 7.x.x and Eslint activated.

Engine

Node < 4.0 will not be supported anymore.


It is my first Hapi contribution, I hope I did not make any mistake :innocent:

Marsup commented 9 years ago

Welcome! :) All dependencies should start with the ES6 versions then, if you can run glue you can run others too.

Marsup commented 9 years ago

What are all those spaces around parentheses?

vdeturckheim commented 9 years ago

@Marsup Thanks ^^

vdeturckheim commented 9 years ago

Sorry for the spamming -_-

Marsup commented 9 years ago

Sorry for the spam as well, I haven't marked all the mistakes on the fat arrow in the tests but you get the idea.

vdeturckheim commented 9 years ago

Thanks for this feedback !

Marsup commented 9 years ago

LGTM, maybe needs a squash now. @csrl ?

vdeturckheim commented 9 years ago

Actually, build is broken since GLUE#484. I will push a new commit tonight (hopefully).

vdeturckheim commented 9 years ago

Build is now passing.

csrl commented 9 years ago

Thanks! I'll review and pull it in over the next few days. Then once Issue #31 is resolved, we can push out Glue 3.0

csrl commented 8 years ago

I've pulled this commit in to the v3 branch. It'll get brought along when that is merged to master.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.