Closed vdeturckheim closed 8 years ago
Welcome! :) All dependencies should start with the ES6 versions then, if you can run glue you can run others too.
What are all those spaces around parentheses?
@Marsup Thanks ^^
Sorry for the spamming -_-
Sorry for the spam as well, I haven't marked all the mistakes on the fat arrow in the tests but you get the idea.
Thanks for this feedback !
LGTM, maybe needs a squash now. @csrl ?
Actually, build is broken since GLUE#484. I will push a new commit tonight (hopefully).
Build is now passing.
Thanks! I'll review and pull it in over the next few days. Then once Issue #31 is resolved, we can push out Glue 3.0
I've pulled this commit in to the v3 branch. It'll get brought along when that is merged to master.
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.
Related to #41
Depedencies
Style
Build is passing with Lab 7.x.x and Eslint activated.
Engine
Node < 4.0 will not be supported anymore.
It is my first Hapi contribution, I hope I did not make any mistake :innocent: