search

hapijs / glue

Server composer for hapi.js
Other
245 stars 62 forks source link

compose() returns a Promise if no callback is provided #54

Closed SimonDegraeve closed 8 years ago

SimonDegraeve commented 8 years ago

Well, supporting Promise in Glue is related to Hapi v12.0.0 supporting Promise. That's why I updated the dependency and the Readme.

SimonDegraeve commented 8 years ago

Anything else? I will do a "force push" to get proper history.

SimonDegraeve commented 8 years ago

What about instanceof Error?

SimonDegraeve commented 8 years ago

You're right, I am not a big fan of this extra file either.

csrl commented 8 years ago

Thanks for the pointer on Hapi 12 supporting promises, and the relationship there. I see that is where the abstract promises.js module came from as well - but since we only have a single use, I think we can do without it.

csrl commented 8 years ago

That's all the feedback I have right now. Thanks.

csrl commented 8 years ago

Oh. The API.md document needs to be updated as well.

csrl commented 8 years ago

I've pushed a commit on top of yours to a 'promises' branch. Please review and let me know if you have any further changes or concerns with the changes I made. Feel free to squash the commit into yours and force push, or it can go out as is.

SimonDegraeve commented 8 years ago

Done ;-)

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.