search

hapijs / glue

Server composer for hapi.js
Other
245 stars 62 forks source link

Add Hapi 16 support #82

Closed h4m3d closed 7 years ago

WesTyler commented 7 years ago

I have a local commit for this, waiting on approval/merging of #84 before pushing/PRing.

AdriVanHoudt commented 7 years ago

@WesTyler You can open the PR for hapi 16 already mentioning the dependency on #84 ;) This also allows the maintainer to close both in one session, which will result in a quicker release ^^

WesTyler commented 7 years ago

@AdriVanHoudt the tests will fail on CI checks if I push them separately. The Joi 10.x upgrade requires #84 to be in place or else an error is thrown.

Is it kosher for me to push both bits into the same PR so that the tests will pass? I know they are both small changes, but I like to keep PRs as focused as possible.

[EDIT] Eh, I went ahead and PR'd.

AdriVanHoudt commented 7 years ago

@WesTyler there is no harm in doing a PR that makes CI fail, we even encourage people to submit PR's with failing tests to 'prove' there is a bug which makes it way easier to fix!

And I do think separate PR's are fine here ^^

Thanks for the contribution!!

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.