search

hapijs / glue

Server composer for hapi.js
Other
245 stars 62 forks source link

This is for issue #89 #95

Closed jorgecuesta closed 7 years ago

jorgecuesta commented 7 years ago

Hi I add function support on registrations: [{plugin: require('./my-awesome-plugin.js')}] because some times to use things like server rendering is needed that webpack or something like that parse imports/require it self. Also let people do it with his own require/import logic. I fix some errors of last pull request I made. Let me know if you need something more.

felixheck commented 7 years ago

What's the progress of this PR? Would be really nice if this one could be merged.

AdriVanHoudt commented 7 years ago

@csrl this seems like the PR you proposed, LGTM

felixheck commented 7 years ago

Tried this PR in a private project in combination with classical plugins like good or inert and plugins with another internal structure (e.g. laabr). Works like a charm and like expected. Good job @jorgecuesta

push

felixheck commented 7 years ago

@nlf any information about the lead maintainer?

csrl commented 7 years ago

Sorry all - I thought I'd merged this long ago. I made some minor adjustments, and pushed out version 4.2.0. Thanks @jorgecuesta

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.