hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

upgrade hapijs dependencies to allow for npm shrinkwrap #424

Closed lancespeelmon closed 8 years ago

lancespeelmon commented 8 years ago
> good@6.4.0 test /Develop/nodejs/good
> lab -m 5000 -t 100 -v -La code

Plugin
  ✔ 1) emits ops data (129 ms)
  ✔ 2) tracks used sockets (1022 ms)
  ✔ 3) wreck data emits (50 ms)
good
  Monitor()
    ✔ 4) throws an error constructed without new (1 ms)
    ✔ 5) throws an error if opsInterval is too small (2 ms)
    ✔ 6) does not throw an error when opsInterval is more than 100 (1 ms)
    ✔ 7) throws an error if responseEvent is not "response" or "tail" (1 ms)
    ✔ 8) supports a mix of reporter options (2 ms)
    ✔ 9) supports passing a module name or path for the reporter function (4 ms)
    ✔ 10) allows starting with no reporters (2 ms)
    ✔ 11) throws an error if invalid extension events are used (2 ms)
  start()
    ✔ 12) calls the init methods of all the reporters (14 ms)
    ✔ 13) callsback with an error if a there is an error in a broadcaster "init" method (2 ms)
    ✔ 14) attaches events for "ops", "tail", "log", and "request-error" (2 ms)
    ✔ 15) validates the incoming reporter objects (1 ms)
    ✔ 16) uses reporter name or index in reporter validation errors (2 ms)
  stop()
    ✔ 17) cleans up open timeouts, removes event handlers, and stops all of the reporters (2 ms)
    ✔ 18) is called on the "stop" server event (2 ms)
  broadcasting
    ✔ 19) sends events to all reporters when they occur (514 ms)
    ✔ 20) provides additional information about "response" events using "requestHeaders","requestPayload", and "responsePayload" (20 ms)
    ✔ 21) filters payloads per the filter rules (11 ms)
    ✔ 22) does not send an "ops" event if an error occurs during information gathering (68 ms)
    ✔ 23) has a standard "ops" event schema (159 ms)
    ✔ 24) has a standard "response" event schema (8 ms)
    ✔ 25) has a standard "error" event schema (8 ms)
    ✔ 26) has a standard "log" event schema (8 ms)
    ✔ 27) has a standard "request" event schema (9 ms)
    ✔ 28) prevents changing the eventData object (9 ms)
    ✔ 29) reports extension events when they occur (9 ms)
Network Monitor
  ✔ 30) reports on network activity (514 ms)
  ✔ 31) resets stored statistics (309 ms)
  ✔ 32) exposes stats via async calls (311 ms)
  ✔ 33) tracks server disconnects (408 ms)
  ✔ 34) error checks getConnections (0 ms)
  ✔ 35) does not throw if request.response is null (8 ms)
Process Monitor
  memory()
    ✔ 36) passes the current memory usage to the callback (0 ms)
  delay()
    ✔ 37) passes the current event queue delay to the callback (1 ms)
System Monitor
  mem()
    ✔ 38) returns an object with the current memory usage (0 ms)
utils
  makeContinuation()
    ✔ 39) successfully creates a continuation function (1 ms)
  GreatWreck()
    ✔ 40) handles a null request and response (0 ms)
    ✔ 41) reports on errors (1 ms)
    ✔ 42) contains the current pid (0 ms)
  GreatResponse()
    ✔ 43) handles empty request payloads (0 ms)
    ✔ 44) handles empty response payloads (1 ms)
    ✔ 45) handles response payloads with a toString() function (0 ms)

45 tests complete
Test duration: 3631 ms
Assertions count: 164 (verbosity: 3.64)
No global variable leaks detected
Coverage: 100.00%
Linting results: No issues
arb commented 8 years ago

Sorry, this is not how we use semver in package.json within the hapi.js organization.

lancespeelmon commented 8 years ago

@arb ok, then what is the best way to work around this blocker to upgrading modules in a hapi project?

npm shrinkwrap --dev                                                                                                                           
npm WARN unmet dependency /Develop/trax/document-service/node_modules/good requires hoek@'2.x.x' but will load
npm WARN unmet dependency /Develop/trax/document-service/node_modules/hoek,
npm WARN unmet dependency which is version 3.0.4
npm WARN unmet dependency /Develop/trax/document-service/node_modules/good requires joi@'6.x.x' but will load
npm WARN unmet dependency /Develop/trax/document-service/node_modules/joi,
npm WARN unmet dependency which is version 7.0.1
npm WARN unmet dependency /Develop/trax/document-service/node_modules/good requires wreck@'6.x.x' but will load
npm WARN unmet dependency /Develop/trax/document-service/node_modules/wreck,
npm WARN unmet dependency which is version 7.0.0
npm ERR! Darwin 15.2.0
npm ERR! argv "/usr/local/Cellar/nvm/0.29.0/versions/node/v4.2.3/bin/node" "/usr/local/opt/nvm/versions/node/v4.2.3/bin/npm" "shrinkwrap" "--dev"
npm ERR! node v4.2.3
npm ERR! npm  v2.14.7

npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! invalid: boom@3.1.0 /Develop/trax/document-service/node_modules/boom
npm ERR! invalid: hoek@3.0.4 /Develop/trax/document-service/node_modules/hoek
npm ERR! invalid: joi@7.0.1 /Develop/trax/document-service/node_modules/joi
npm ERR! invalid: wreck@7.0.0 /Develop/trax/document-service/node_modules/wreck
Marsup commented 8 years ago

I think that should be solved by upgrading to npm 3.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.