search

hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

Update dependencies #436

Closed achingbrain closed 8 years ago

achingbrain commented 8 years ago

I've got quite a lot of copies of Wreck in my node_modules folder - this means that a lot of logging doesn't occur because Wreck is a singleton.

This PR updates the project dependencies to the latest versions (including Wreck 7).

I hope you'll consider merging this, happy to make whatever amends are necessary.

Marsup commented 8 years ago

We have a no ^ policy in this org.

AdriVanHoudt commented 8 years ago

you should keep the x.x.x notation and the new version of hoek does not work on older node versions so your build breaks

achingbrain commented 8 years ago

Is it worth still supporting older node versions? Looks like most of the hapi/* modules are moving to 4+ only.

arb commented 8 years ago

As you can see, the build does not pass because this version of good still supports older versions of both hapi and node. I'm not willing to release a breaking change just to update dependencies. The next version (7) of good will include all of these new dependencies and will only support node >= 4.x.x and the corresponding versions of hapi.

As far as the Wreck issue... you can try using npm3 and deduping and see if that helps at all. It is a known issue with Wreck as it is a singleton.

achingbrain commented 8 years ago

Fair enough. Do you know when good 7 will land?

arb commented 8 years ago

Nope. Like I tell everyone, if you want to grease the wheels, maybe get your employer to sponsor it? Some details about that here.

achingbrain commented 8 years ago

Also fair enough. Do you have a hit list for things that need doing? Just update deps and convert everything to ES6 until the tests pass and the linter stops complaining? Would you accept a PR that does that?

My employer is me so I'm happy to spend some time on this if it helps.

arb commented 8 years ago

On any hapi repo, you can just go to issues and look for ones that have a milestone attached to them. In this case - https://github.com/hapijs/good/issues?q=is%3Aopen+is%3Aissue+milestone%3A7.0.0+no%3Aassignee

achingbrain commented 8 years ago

Hmm, none of those appear to be 'Update Wreck'. Indeed, #402 is to remove Wreck logging entirely which I always thought was very useful once you get used to encouraging the owners of modules you depend on to use the same version of Wreck.

arb commented 8 years ago

That isn't a realistic solution to the problem. If you wish to continue the discussion, comment on the linked issue.

Also, please see the discussion here.

achingbrain commented 8 years ago

Ha, I wasn't suggesting it was, just a reality of trying to get logs out of Wreck consistently :wink:

Anyway - point taken.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.