search

hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

Closes #485 #495

Closed genediazjr closed 8 years ago

genediazjr commented 8 years ago

updated to include gitignores

gergoerdosi commented 8 years ago

Many of these are ignored by default: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package

genediazjr commented 8 years ago

@arb is this ok?

arb commented 8 years ago

Might as well add tests, 'API.md' and 'CONTRIBUTING.md' to that too.

Check out how joi did it here. So that the stuff in .gitignore is automatically kept in sync. Let's follow suit here.

vdeturckheim commented 8 years ago

@arb regarding API.md: I like the fact to get packages from npm with their documentation.(Sometimes, I dev offline and I happen to go through 'node_modules' to find doc)

genediazjr commented 8 years ago

I agree with @vdeturckheim. what do you think @arb?

arb commented 8 years ago

API.md can stay too; if makes sense if you're offline.

Marsup commented 8 years ago

@arb we didn't really agree on that on contrib.

arb commented 8 years ago

Who are we waiting on? Does this have to be something that is the same for every repo? A bunch of other repos have already added a .npmignore file without waiting for consensus.

Marsup commented 8 years ago

Fair enough.

arb commented 8 years ago

Sorry for all the churn and thanks for contributing!

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.