search

hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

help migrating v6 to v7 #500

Closed gr2m closed 8 years ago

gr2m commented 8 years ago

follow up for https://github.com/hapijs/good/issues/467#issuecomment-226545353

The update to v7 broke our usage at Hoodie, here’s a pull request with failing test on Travis: https://github.com/hoodiehq/hoodie/pull/478 – that’s expected and clear, it’s a breaking change after all.

I tried to look into it myself and figure out how to adapt our good usage in this file: https://github.com/hoodiehq/hoodie/blob/master/server/plugins/logger.js but had no luck.

I’d appreciate if you could give me some pointers on how to best migrate to v7, thanks a lot

arb commented 8 years ago

If you're committed to using npmlog, you'll have to write your own write stream, implement a _write method and then call into the npmlog like you're doing now. Check good-http for an example. Specifically the _write method. In there you'd check the event type and call the different npmlog methods.

You can remove the GoodFilter out of there too if you want and include an instance of it before your new write stream to keep your writeStream more modular.

I'm available for private instruction and all I'll ask for is a hoodie 😄

gr2m commented 8 years ago

Thanks for the pointers :) I’ll give it another try!

Unfortunately we don’t have a Hoodie hoodie yet. I know, I know. But it keeps us going, it’s something we want to earn with big public release, and we are not there yet ;)

arb commented 8 years ago

I will also take USD as well 😉 If you're interested, email me and we can set something up.

gr2m commented 8 years ago

we are a poor open source project with no moneys, I’m afraid ¯_(ツ)_/¯ but thanks for your help Adam, we’ll figure it out :)

arb commented 8 years ago

Alrighty; good luck!

lancespeelmon commented 8 years ago

FYI - we just converted to good7 - this diff may help you... https://github.com/lancespeelmon/gooder-bunyan/commit/87ccb856873d742e9bf715d58b24253a8db0e11c Best, L

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.