hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

Add request route tags to response event #516

Closed csabapalfi closed 8 years ago

csabapalfi commented 8 years ago

to enable filtering with good-squeeze

AdriVanHoudt commented 8 years ago

Why not expose request.route.settings as a whole?

AdriVanHoudt commented 8 years ago

Also the build is failing due to Line 85: no-trailing-spaces - Trailing spaces not allowed. ;)

csabapalfi commented 8 years ago

Ouch, sorry.

The reason for exposing tags at the top level because that's how squeeze looks for them: https://github.com/hapijs/good-squeeze/blob/master/lib/squeeze.js#L65

AdriVanHoudt commented 8 years ago

ah I see then 👍

arb commented 8 years ago

Can you update the documentation to include this new field?

csabapalfi commented 8 years ago

Sure, added docs for this new field.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.