search

hapijs / good

hapi process monitoring
Other
525 stars 160 forks source link

Update Tests #519

Closed arb closed 7 years ago

arb commented 7 years ago

Now that we support functions again as arguments, use them more often to make tests easier to read and understand.

jdcormack commented 7 years ago

I would like to help, can you tell me more?

arb commented 7 years ago

Rather than pass strings as modules, just pass function constructors.

https://github.com/hapijs/good/commit/ae1778ba6f2902bf9d52f497dd3c7db5d07c195e

omerbn commented 7 years ago

I would like to help, but didn't understand what exactly do you need. Can you elaborate?

arb commented 7 years ago

In places like https://github.com/hapijs/good/blob/master/test/monitor.js#L145-L151 we pass a string as module. Now that you can pass constructor functions as the module value, we can update many of these tests to pass functions instead of strings.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.