search

hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

added info about reporter types #524

Closed yonjah closed 7 years ago

yonjah commented 8 years ago

As described at #518

arb commented 7 years ago

Are you still interested in landing this? If not, I'm going to close it.

yonjah commented 7 years ago

I think this is important information for plugin developers. Maybe I misunderstood the self assignment. I thought your going to do what ever changes you wanted and merge. I can do some of the changes but I think there are some things I don't still fully understand. Mainly about just using streams (and changing terminology from reporters to streams). I was aiming this to developers who specifically target building Reporters/Streams to be used with good but if the direction is actually using any stream it might be more important for the user to verify the stream type (which means digging a bit in 3rd party code)

arb commented 7 years ago

The self assignment just means I'm responsible for reviewing and merging the PR.

If you don't have the time to make the suggested adjustments, that OK. I'll just close this and you can re-open later when you've got time.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.