search

hapijs / good

hapi process monitoring
Other
525 stars 160 forks source link

Don't create a reporter if no streams were provided. Addresses #534 #535

Closed ianwsperber closed 7 years ago

ianwsperber commented 7 years ago

Decided the simplest solution was just to not create the reporter if no stream is provided.

See #534

arb commented 7 years ago

Can you update the test to include two reporters, one with enough streams, and one with 0, just to make sure the return doesn't short-circuit the rest of the loop?

ianwsperber commented 7 years ago

Good idea @arb - I've updated the test per suggestion

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.