search

hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

Response even timestamp in based on received time, not responded time #551

Closed lbland closed 7 years ago

lbland commented 7 years ago

I do not know if this is by design or a bug, but the RequestSent class sets a timestamp to the request.info.received time. This causes logs to have events in logical order, but the timestamps will look out of order. This is used for response events, so it would make more sense to use this.timestamp = Date.now() or this.timestamp = request.info.responded

Is there a reason for this that i am missing?

lbland commented 7 years ago

552

arb commented 7 years ago

Trumped by #531

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.