search

hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

Fix for 557: Provide request headers in various payload events #562

Closed bodawei closed 7 years ago

bodawei commented 7 years ago

This is a draft fix for https://github.com/hapijs/good/issues/557 . In particular, this demonstrates what I have in mind there. Happy to discuss this in more detail.

bodawei commented 7 years ago

I noticed that some of the Travis CI build failed. I don't get these same problems on my local system (notably, one of these seems to be missing some module (!), and others are about a "leak" of WebAssembly). Any insights into what is up with this?

arb commented 7 years ago

Yes. An update to lab fixes the memory leak issue (it's not really a leak btw, just a global variable). Missing modules I'm not sure about... I haven't seen that locally or in any of my Travis runs. There are still failing tests because, surprise surprise, things changed in the stream API so it doesn't act the same in the 4 versions of node good is tested against.

bodawei commented 7 years ago

I looked closer and noticed that all the errors in this build are the same as the ones from https://github.com/hapijs/good/pull/553. Given that that is merely a .md file change, seems like it's not likely my change caused these. So, this change seems good to go to me. Let me know!

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.