search

hapijs / good

hapi process monitoring
Other
525 stars 161 forks source link

hapi v17 support #568

Closed hueniverse closed 6 years ago

hueniverse commented 7 years ago

What's the plan? Migrate? Deprecate?

arb commented 7 years ago

Migration shouldn't be difficult but I really don't have the time to change the reporting interface again. I didn't get a strong opinion either way in the slack about deprecating good or not. The npm downloads, which I realize aren't a perfect metric, is in the thousands per day so people must be using it.

corbinu commented 7 years ago

I am using it but would be open to transition what would the plan be to migrate to? Winston or something else?

BorntraegerMarc commented 7 years ago

@arb is there an ETA when we could expect an update? Now that hapi v17 final has been released 😄

AdriVanHoudt commented 7 years ago

If you want v17 support for this the best way is to submit a PR ;)

PizzaBrandon commented 7 years ago

I like good and want it to survive. I'll take a crack at this and see what I can do, but I also encourage others to take up the cause, too.

If good is deprecated, what (if anything) is its replacement?

geraintguan commented 7 years ago

I quite like and am currently using good. I'll have a stab at migrating and opening a PR. :smile:

corbinu commented 6 years ago

@g-corneu Any luck? Otherwise I will take a stab also

geraintguan commented 6 years ago

@corbinu I'm finishing up porting oppsy and am hoping to open a PR for that in the next couple of days since good depends on it. I'll move on to porting good after that; should be able to spend some dedicated time on it this weekend + first 2 days of next week. Happy to work together if you're interested and free.

corbinu commented 6 years ago

@g-corneu I finally had some time now that it is after Black Friday. I have a version of oppsy that is ready to go and have made some progress on good. Would be happy to sync up if you like.

geraintguan commented 6 years ago

@g-corneu I finally had some time now that it is after Black Friday. I have a version of oppsy that is ready to go and have made some progress on good. Would be happy to sync up if you like.

I've had a lot less free time than I thought I would. :(

Feel free to do the PRs, if there's anything I can help with give me a shout. :)

-- Geraint Corneu Full Stack Developer @ Appointedd

For my public PGP key or secure communications you can find me on Keybase.

For other ways of contacting me visit my landing page.

corbinu commented 6 years ago

No worries TOTALLY know that feeling good luck!

Will do thanks mostly now just doing more upgrades to node 8 syntax rather than just getting them working.

lostthetrail commented 6 years ago

@arb @hueniverse My understanding was that Good was the standard logging plugin for Hapi.js. What are y'all using that makes Good a potential target for deprecation?

hueniverse commented 6 years ago

@lostthetrail people use a bunch of different solutions. I use my own.

framerate commented 6 years ago

@lostthetrail people use a bunch of different solutions. I use my own.

Do you have any examples? I've been using good for a few years now and would love to investigate some v17 compatible alternatives!

corbinu commented 6 years ago

Just an update I am digging through the last few issues and waiting for release of my oppsy update. Hoping to have a PR up in the next few days. Work just keeps getting in my way.

corbinu commented 6 years ago

Pushed up my progress here: https://github.com/corbinu/good

Turned out some of the errors are just that goods current test suite fails on OS X. It is green on Linux now.

However I am getting an warning from node: "Possible EventEmitter memory leak detected. 11 end listeners added. Use emitter.setMaxListeners() to increase limit"

It does drop support for Wreck logging as the global events were removed in the most recent versions of Wreck.

Feel free to try it out and give feedback!

framerate commented 6 years ago

@corbinu I set it up in its most basic form and I have route logging printing now, so far so good!

fhemberger commented 6 years ago

@framerate For simple logging I switched to bunyan (using hapi-bunny). As I mostly run containerized Node.js applications these days, I only need to log to stdout/stderr. Ops related stats are handled by Docker or Prometheus (https://github.com/siimon/prom-client).

arb commented 6 years ago

Closed via #572

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.